Repository navigation
fix: let visitors retry failed Pulse Check loads - #150
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulse Check now offers Retry after a failed catalog load, announces loading while the next request is pending, and restores the existing sample dashboard on success. Another failure keeps recovery available; the sample-data notice stays visible in every state.
Part of #85
Closes #149
Verified in this worktree
MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run installpassed with peer-dependency warnings and no lockfile changes.MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run lintpassed TypeScript and ESLint across all five workspaces.MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run test -- --runInBand --verbosepassed 71 tests in 10 suites, with one existing skipped test and suite.BROWSER=none MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run devcompiled successfully and initialised the backend plugins./pulse-checkreturned HTTP 200. The dev stack was stopped after verification.git diff --check origin/main...HEADpassed.mise run buildwas not run locally because this slice changes frontend controls and component tests only. The PR Build workflow runs all four mise gates, including the Docker image build.Screenshot method (a) was blocked because the browser tool returned "The browser access host is unavailable" when opening
/pulse-check. No screenshot was captured and browser rendering remains unverified. Method (b) succeeded with the regression-test output below. The verification transcript contains the complete Pulse Check test result block, suite totals, lint output and dev-server checks.The three added regression cases passed
The tests check that Retry and the old error disappear during a pending request, the service-only catalog filter is preserved, successful recovery restores service cards and example metrics, and a later empty response retains the existing empty-catalog message. Non-Error rejections now show a fallback error instead of being mistaken for success. Responses from an obsolete effect are ignored. Existing jsdom stylesheet and React/MUI warnings appeared during the suite; the dev server also reported the existing signals events-backend 404.
The parent epic stays open. A browser capture of failure and recovery remains a follow-up when browser access is available; public-demo baseline and landing-page taste decisions remain with Johnny.